From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751923AbdAPVgN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Jan 2017 16:36:13 -0500
Received: from mail-ua0-f195.google.com ([209.85.217.195]:34163 "EHLO
        mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751481AbdAPVf5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Jan 2017 16:35:57 -0500
Date: Mon, 16 Jan 2017 19:35:51 -0200
From: Gustavo Padovan <gustavo@padovan.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Rongrong Zou <zourongrong@gmail.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        Chen Feng <puck.chen@hisilicon.com>, David Airlie <airlied@linux.ie>,
        Wei Yongjun <weiyongjun1@huawei.com>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to
 PTR_ERR()
Message-ID: <20170116213551.GK16017@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
        Wei Yongjun <weiyj.lk@gmail.com>,
        Rongrong Zou <zourongrong@gmail.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        Chen Feng <puck.chen@hisilicon.com>,
        David Airlie <airlied@linux.ie>,
        Wei Yongjun <weiyongjun1@huawei.com>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20170112151921.16538-1-weiyj.lk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170112151921.16538-1-weiyj.lk@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Wei,

2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> PTR_ERR should access the value just tested by IS_ERR, otherwise
> the wrong error code will be returned.
> 
> Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo