* [PATCH -next] drm/atomic: make release_crtc_commit() static
@ 2017-01-12 14:21 Wei Yongjun
2017-01-16 21:36 ` Gustavo Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2017-01-12 14:21 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie
Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
symbol 'release_crtc_commit' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/drm_atomic_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 7b71ac4..e2e5a74 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1357,7 +1357,7 @@ static int stall_checks(struct drm_crtc *crtc, bool nonblock)
return ret < 0 ? ret : 0;
}
-void release_crtc_commit(struct completion *completion)
+static void release_crtc_commit(struct completion *completion)
{
struct drm_crtc_commit *commit = container_of(completion,
typeof(*commit),
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/atomic: make release_crtc_commit() static
2017-01-12 14:21 [PATCH -next] drm/atomic: make release_crtc_commit() static Wei Yongjun
@ 2017-01-16 21:36 ` Gustavo Padovan
2017-01-23 8:01 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Padovan @ 2017-01-16 21:36 UTC (permalink / raw)
To: Wei Yongjun
Cc: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, Wei Yongjun,
linux-kernel, dri-devel
Hi Wei,
2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
> symbol 'release_crtc_commit' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/atomic: make release_crtc_commit() static
2017-01-16 21:36 ` Gustavo Padovan
@ 2017-01-23 8:01 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-01-23 8:01 UTC (permalink / raw)
To: Gustavo Padovan, Wei Yongjun, Daniel Vetter, Jani Nikula,
Sean Paul, David Airlie, Wei Yongjun, linux-kernel, dri-devel
On Mon, Jan 16, 2017 at 07:36:27PM -0200, Gustavo Padovan wrote:
> Hi Wei,
>
> 2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:
>
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > Fixes the following sparse warning:
> >
> > drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
> > symbol 'release_crtc_commit' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Thanks for the patch, applied to drm-misc.
Gustavo, for next time around please just use your commit rights when
reviewing a simple patch like this :-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-23 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 14:21 [PATCH -next] drm/atomic: make release_crtc_commit() static Wei Yongjun
2017-01-16 21:36 ` Gustavo Padovan
2017-01-23 8:01 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox