From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750957AbdAQHl5 (ORCPT ); Tue, 17 Jan 2017 02:41:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58194 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdAQHl2 (ORCPT ); Tue, 17 Jan 2017 02:41:28 -0500 Date: Tue, 17 Jan 2017 08:41:40 +0100 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging: lustre: headers: potential UAPI headers Message-ID: <20170117074140.GA19328@kroah.com> References: <1482167207-22800-1-git-send-email-jsimmons@infradead.org> <20170103141248.GA8695@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 09:28:30PM +0000, James Simmons wrote: > > > On Mon, Dec 19, 2016 at 12:06:47PM -0500, James Simmons wrote: > > > Not for landing. This is the purposed UAPI headers > > > with the removal of unlikely and debugging macros. > > > This is just for feedback to see if this is acceptable > > > for the upstream client. > > > > > > Signed-off-by: James Simmons > > > --- > > > .../lustre/lustre/include/lustre/lustre_fid.h | 353 +++++++++++++++++++++ > > > .../lustre/lustre/include/lustre/lustre_ostid.h | 233 ++++++++++++++ > > > > Can you make a lustre "uapi" directory so we can see which files you > > really want to be UAPI and which you don't as time goes on? > > Where do you want them placed? In uapi/linux/lustre or uapi/lustre. Does > it matter to you? The below was to forth coming UAPI headers which from > your response you seem okay with in general. How many .h files are there going to be? It's just a single filesystem, shouldn't you just need a single file? If so, how about drivers/staging/lustre/include/uapi/lustre.h ? If you really need multiple .h files, put them all in the same uapi/ directory with a lustre_ prefix, you don't need a whole subdir just for yourself, right? thanks, greg k-h