From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751041AbdAQI2J (ORCPT ); Tue, 17 Jan 2017 03:28:09 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:24608 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbdAQI2H (ORCPT ); Tue, 17 Jan 2017 03:28:07 -0500 Date: Tue, 17 Jan 2017 11:27:09 +0300 From: Dan Carpenter To: Dhananjay Balan Cc: Stuart Yoder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fsl-mc: fix coding stye errors Message-ID: <20170117082708.GC4051@mwanda> References: <20170117081128.wrmdicglnwifu2mi@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170117081128.wrmdicglnwifu2mi@gaia> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote: > Split line at boolean operator. > > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' > > Signed-off-by: Dhananjay Balan > --- > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > index 6b1cd57..6b19a21 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void) > continue; > } > > - WARN_ON(mc_msi_domain-> > - host_data != &its_fsl_mc_msi_domain_info); > + WARN_ON(mc_msi_domain->host_data != > + &its_fsl_mc_msi_domain_info); Better to line it up like this: WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info); regards, dan carpenter