From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdAQOkd (ORCPT ); Tue, 17 Jan 2017 09:40:33 -0500 Received: from mail.kernel.org ([198.145.29.136]:54038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdAQOjM (ORCPT ); Tue, 17 Jan 2017 09:39:12 -0500 Date: Tue, 17 Jan 2017 11:39:06 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Minchan Kim , David Ahern Subject: Re: [PATCH 1/3] perf sched timehist: Account thread wait time separately Message-ID: <20170117143906.GD14872@kernel.org> References: <20170113104523.31212-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113104523.31212-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jan 13, 2017 at 07:45:21PM +0900, Namhyung Kim escreveu: > @@ -1943,8 +1968,16 @@ static void timehist_update_runtime_stats(struct thread_runtime *r, > > if (r->last_time > tprev) > pr_debug("time travel: last sched out time for task > previous sched_switch event\n"); > - else if (r->last_time) > - r->dt_wait = tprev - r->last_time; > + else if (r->last_time) { > + u64 wait = tprev - r->last_time; > + > + if (r->last_state == TASK_RUNNING) > + r->dt_preempt = wait; > + else if (r->last_state == TASK_UNINTERRUPTIBLE) > + r->dt_iowait = wait; > + else > + r->dt_sleep = wait; > + } s/wait/dt_wait/g to fix the build on older distros where 'wait' shadows a global declaration. - Arnaldo