From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdAQP0e (ORCPT ); Tue, 17 Jan 2017 10:26:34 -0500 Received: from merlin.infradead.org ([205.233.59.134]:45966 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdAQP0d (ORCPT ); Tue, 17 Jan 2017 10:26:33 -0500 Date: Tue, 17 Jan 2017 16:26:18 +0100 From: Peter Zijlstra To: Vikas Shivappa Cc: vikas.shivappa@intel.com, davidcc@google.com, eranian@google.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Message-ID: <20170117152618.GD5680@worktop> References: <1483740005-23499-1-git-send-email-vikas.shivappa@linux.intel.com> <1483740005-23499-6-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483740005-23499-6-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 01:59:58PM -0800, Vikas Shivappa wrote: > - Introduce event_terminate as event_destroy is called after cgrp is > disassociated from the event to support rmid handling of the cgroup. > This helps cqm clean up the cqm specific arch_info. You've not even tried to audit the code to see if you can either move the existing ->destroy() invocation or the perf_detach_cgroup() one, have you? Minimal APIs are a good thing, don't expand unless you absolutely have to.