From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbdARL4w (ORCPT ); Wed, 18 Jan 2017 06:56:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51566 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdARL4v (ORCPT ); Wed, 18 Jan 2017 06:56:51 -0500 Date: Wed, 18 Jan 2017 12:56:48 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Message-ID: <20170118115648.GA7336@krava> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-3-andi@firstfloor.org> <20170108185741.GA14072@krava> <20170110011005.GC26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110011005.GC26852@two.firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 18 Jan 2017 11:56:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 05:10:05PM -0800, Andi Kleen wrote: > > > for (f = fields; f->field; f++) > > > if (json_streq(map, field, f->field) && nz) { > > > + /* Handle all variations of 0 encounted in JSON */ > > > + if (json_streq(map, val, "0x00") || > > > + json_streq(map, val, "0x0")) > > > + return 1; > > > > how is this related to the patch? also shouldn't it return 0 ? > > I removed it now. It avoids some extra umask=0x0 entries, but these > don't hurt. ack on the version in the branch, but you haven't posted that one jirka