From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdARNV7 (ORCPT ); Wed, 18 Jan 2017 08:21:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbdARNV4 (ORCPT ); Wed, 18 Jan 2017 08:21:56 -0500 Date: Wed, 18 Jan 2017 14:10:50 +0100 From: Jiri Olsa To: Matija Glavinic Pecotic Cc: linux-kernel@vger.kernel.org, namhyung@kernel.org, acme@redhat.com, Masami Hiramatsu , "Sverdlin, Alexander (Nokia - DE/Ulm)" Subject: Re: [PATCH] perf: Fix looking up dwarf unwind stack info Message-ID: <20170118131050.GA22162@krava> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 18 Jan 2017 13:10:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 03:50:35PM +0100, Matija Glavinic Pecotic wrote: SNIP > extern int > UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as, > @@ -297,15 +298,58 @@ static int read_unwind_spec_debug_frame(struct dso *dso, > int fd; > u64 ofs = dso->data.debug_frame_offset; > > + /* debug_frame can reside in: > + * - dso > + * - debug pointed by symsrc_filename > + * - gnu_debuglink, which doesn't necessary > + * has to be pointed by symsrc_filename > + */ looks like we could use this in other parts, like when __get_srcline and similar Acked-by: Jiri Olsa thanks, jirka