From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754119AbdARO0X (ORCPT ); Wed, 18 Jan 2017 09:26:23 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:38432 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbdARO0T (ORCPT ); Wed, 18 Jan 2017 09:26:19 -0500 Date: Wed, 18 Jan 2017 15:26:08 +0100 From: Peter Zijlstra To: Hari Bathini Cc: ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com, jolsa@redhat.com Subject: Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info Message-ID: <20170118142608.GF6515@twins.programming.kicks-ass.net> References: <148466259095.32153.10361763951552633449.stgit@hbathini.in.ibm.com> <148466262903.32153.14129217679474433212.stgit@hbathini.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148466262903.32153.14129217679474433212.stgit@hbathini.in.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 07:47:22PM +0530, Hari Bathini wrote: > With the advert of container technologies like docker, that depend > on namespaces for isolation, there is a need for tracing support for > namespaces. This patch introduces new PERF_RECORD_NAMESPACES event > for tracing based on namespaces related info. This fails to mention the whole namespace of namespaces issue Eric brought up. Where are we on that, and or why isn't it required? > +/* > + * The maximum size of the name of each namespace > + */ > +#define NS_NAME_SIZE 8 > + > +struct perf_ns_link_info { > + char name[NS_NAME_SIZE]; Do we really need a name? why? > + __u64 dev; > + __u64 ino; > +}; > +