From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbdARPzE (ORCPT ); Wed, 18 Jan 2017 10:55:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbdARPzC (ORCPT ); Wed, 18 Jan 2017 10:55:02 -0500 Date: Wed, 18 Jan 2017 16:54:52 +0100 From: Miroslav Lichvar To: Marcelo Tosatti Cc: Paolo Bonzini , Radim Krcmar , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [patch 3/3] PTP: add kvm PTP driver Message-ID: <20170118155452.GM14227@localhost> References: <20170116193655.GA7649@amt.cnet> <20170116194715.GA8017@amt.cnet> <20170116200112.GB8739@amt.cnet> <20170117080327.GG14227@localhost> <20170117113052.GA27759@amt.cnet> <20170117153621.GE31452@potion> <20170118121738.GA14832@amt.cnet> <20170118122456.GC13762@amt.cnet> <94a761cb-8bcd-e1a6-d07e-02fedc423e33@redhat.com> <20170118142409.GA9713@amt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118142409.GA9713@amt.cnet> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 18 Jan 2017 15:54:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 12:24:09PM -0200, Marcelo Tosatti wrote: > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > I'd rather use PTP_SYS_OFFSET_PRECISE instead, but unfortunately chrony > > does not support it---but I would still prefer you to support > > PTP_SYS_OFFSET_PRECISE as well. > > Sure, I'll check if it makes sense to implement PTP_SYS_OFFSET_PRECISE for > KVM case. But is it really so precise that the application can safely assume there are no errors due to asymmetric delays, etc? I think PTP_SYS_OFFSET_PRECISE should be supported only if the accuracy of the offset measured between the HW and system clock is not worse than the precision of the system clock (typically few tens of nanoseconds). It would be good to verify the accuracy of the offset when the host and guest clocks are synchronised to each other over PTP using two NICs with HW timestamping. -- Miroslav Lichvar