From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751894AbdATKen (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Jan 2017 05:34:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33530 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751661AbdATKel (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Jan 2017 05:34:41 -0500
Date: Wed, 18 Jan 2017 13:57:17 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Richard Cochran <richardcochran@gmail.com>
Subject: Re: [patch 3/3] PTP: add kvm PTP driver
Message-ID: <20170118155717.GA29807@amt.cnet>
References: <20170117080327.GG14227@localhost>
 <20170117113052.GA27759@amt.cnet>
 <20170117153621.GE31452@potion>
 <20170118121738.GA14832@amt.cnet>
 <20170118122456.GC13762@amt.cnet>
 <94a761cb-8bcd-e1a6-d07e-02fedc423e33@redhat.com>
 <20170118133614.GK14227@localhost>
 <255c35c1-4400-7e52-8cb0-bf5a344e9f74@redhat.com>
 <20170118144955.GC9713@amt.cnet>
 <b5ceb5b1-ba55-f84c-d332-a4414c22dc9a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b5ceb5b1-ba55-f84c-d332-a4414c22dc9a@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 20 Jan 2017 10:23:55 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 18, 2017 at 04:45:07PM +0100, Paolo Bonzini wrote:
> 
> 
> On 18/01/2017 15:50, Marcelo Tosatti wrote:
> >> Interesting idea!  For this to work, KVM needs to implement
> >> getcrosstimestamp and ptp_chardev.c can then add an alternative
> >> implementation of PTP_SYS_OFFSET, based on precise cross timestamps.
> >>
> >> Something like
> >>
> >>                 for (i = 0; i <= sysoff->n_samples; i++) {
> >> 			// ... call getcrosststamp ...
> >> 			sysns = ktime_to_ns(xtstamp.sys_realtime);
> >> 			if (i > 0) {
> >> 				devns = ktime_to_ns(xtstamp.device);
> >> 				devns -= (sysns - prev_sysns) / 2;
> >> 				devts = ns_to_timespec(devns);
> >> 				pct->sec = devts.tv_sec;
> >> 				pct->nsec = devts.tv_nsec;
> >> 	                        pct++;
> >> 			}
> >> 			systs = ns_to_timespec(sysns);
> >>                         pct->sec = ts.tv_sec;
> >>                         pct->nsec = ts.tv_nsec;
> >>                         pct++;
> >> 			prev_sysns = sysns;
> >>                 }
> >>
> >> Marcelo, can you give it a try?
> > 
> > Can convert fine, but problem is the simultaneous read
> > of host and guest clocks.
> 
> Could the TSC from the hypercall be applied to kvmclock to do this?  My
> understanding is that get_device_system_crosststamp (which is used in
> the sole in-tree implementation of getcrosststamp) already contains all
> the logic to do that.
> 
> Paolo

Yeah feed that TSC to pvclock_clocksource_read.

Cool will take a look at that function thanks.