From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] perf diff: Fix -o/--order option behavior (again)
Date: Wed, 18 Jan 2017 19:26:32 +0100 [thread overview]
Message-ID: <20170118182632.GC19212@krava> (raw)
In-Reply-To: <20170118051457.30946-2-namhyung@kernel.org>
On Wed, Jan 18, 2017 at 02:14:57PM +0900, Namhyung Kim wrote:
> The commit 21e6d8428664 changed list_add() to
> perf_hpp__register_sort_field(). However this resulted in a behavior
> change since the field was added to the tail instead of the head. So
> the -o option is mostly ignored due to its order in the list.
>
> This patch fixes it by adding perf_hpp__prepend_sort_field().
>
> Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-01-18 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 5:14 [PATCH 1/2] perf diff: Fix segfault on perf diff -o N option Namhyung Kim
2017-01-18 5:14 ` [PATCH 2/2] perf diff: Fix -o/--order option behavior (again) Namhyung Kim
2017-01-18 18:26 ` Jiri Olsa [this message]
2017-02-03 19:47 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2017-01-18 18:20 ` [PATCH 1/2] perf diff: Fix segfault on perf diff -o N option Jiri Olsa
2017-02-02 2:43 ` Namhyung Kim
2017-02-02 14:34 ` Arnaldo Carvalho de Melo
2017-02-03 19:46 ` [tip:perf/urgent] perf diff: Fix segfault on 'perf diff -o N' option tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118182632.GC19212@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox