From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbdARTYG (ORCPT ); Wed, 18 Jan 2017 14:24:06 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36643 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbdARTX6 (ORCPT ); Wed, 18 Jan 2017 14:23:58 -0500 Date: Wed, 18 Jan 2017 11:23:06 -0800 From: Dmitry Torokhov To: Guenter Roeck Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 25/33] Input: atmel-wm97xx - Drop unnecessary error messages and other changes Message-ID: <20170118192306.GC33920@dtor-ws> References: <1484761614-12225-1-git-send-email-linux@roeck-us.net> <1484761614-12225-26-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484761614-12225-26-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 09:46:46AM -0800, Guenter Roeck wrote: > Error messages after memory allocation failures are unnecessary and > can be dropped. > > This conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Drop unnecessary braces around conditional return statements > - Drop error message after devm_kzalloc() failure OK since it was emitted as dev_dbg() anyway, applied. > > Signed-off-by: Guenter Roeck > --- > drivers/input/touchscreen/atmel-wm97xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel-wm97xx.c b/drivers/input/touchscreen/atmel-wm97xx.c > index 7ec0421c0dd8..8cf0b2be2df4 100644 > --- a/drivers/input/touchscreen/atmel-wm97xx.c > +++ b/drivers/input/touchscreen/atmel-wm97xx.c > @@ -339,10 +339,8 @@ static int __init atmel_wm97xx_probe(struct platform_device *pdev) > int ret; > > atmel_wm97xx = kzalloc(sizeof(struct atmel_wm97xx), GFP_KERNEL); > - if (!atmel_wm97xx) { > - dev_dbg(&pdev->dev, "out of memory\n"); > + if (!atmel_wm97xx) > return -ENOMEM; > - } > > atmel_wm97xx->wm = wm; > atmel_wm97xx->regs = (void *)ATMEL_WM97XX_AC97C_IOMEM; > -- > 2.7.4 > -- Dmitry