From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbdARTbY (ORCPT ); Wed, 18 Jan 2017 14:31:24 -0500 Received: from mail.windriver.com ([147.11.1.11]:61405 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdARTbX (ORCPT ); Wed, 18 Jan 2017 14:31:23 -0500 Date: Wed, 18 Jan 2017 14:31:13 -0500 From: Paul Gortmaker To: Andy Shevchenko CC: "linux-kernel@vger.kernel.org" , Kostenzer Felix , Andrew Morton Subject: Re: [PATCH] lib: sort: make it explicitly non-modular Message-ID: <20170118193112.GE29778@windriver.com> References: <20170118162009.24763-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH] lib: sort: make it explicitly non-modular] On 18/01/2017 (Wed 20:03) Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 6:20 PM, Paul Gortmaker > wrote: > > The Makefile currently controlling compilation of this code is: > > > > lib/Kconfig.debug:config TEST_SORT > > lib/Kconfig.debug: bool "Array-based sort test" > > > > and... > > > > lib/Makefile:obj-y += bcd.o div64.o sort.o [...] > > > > ...meaning that it currently is not being built as a module by anyone. > > Perhaps allow it to be a module? If anything, I'd argue the other way and say we shouldn't be further polluting Kconfig space with more super specific options. Instead something more generic like CONFIG_ENABLE_BOOT_SELF_TESTS that at least could be shared. There is no real value in making something a module when it could just as easily be thrown out as __init code/data. > > Besides that perhaps rename to something like test_sort.c ? The sort.c was not added just for the test code ; it already existed for the sort code itself. Paul. -- > > -- > With Best Regards, > Andy Shevchenko