From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbdART5y (ORCPT ); Wed, 18 Jan 2017 14:57:54 -0500 Received: from mail.us.es ([193.147.175.20]:37356 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbdART5w (ORCPT ); Wed, 18 Jan 2017 14:57:52 -0500 Date: Wed, 18 Jan 2017 20:57:43 +0100 From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Xin Long , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipt_CLUSTERIP: fix build error without procfs Message-ID: <20170118195743.GA14797@salvia> References: <20170113154204.2737978-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113154204.2737978-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 04:41:03PM +0100, Arnd Bergmann wrote: > We can't access c->pde if CONFIG_PROC_FS is disabled: > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_config_find_get': > net/ipv4/netfilter/ipt_CLUSTERIP.c:147:9: error: 'struct clusterip_config' has no member named 'pde' > > This moves the check inside of another #ifdef. > > Fixes: 6c5d5cfbe3c5 ("netfilter: ipt_CLUSTERIP: check duplicate config when initializing") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.