From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbdARWkC (ORCPT ); Wed, 18 Jan 2017 17:40:02 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:49576 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdARWkA (ORCPT ); Wed, 18 Jan 2017 17:40:00 -0500 Date: Wed, 18 Jan 2017 22:39:48 +0000 From: Russell King - ARM Linux To: Florian Fainelli Cc: Petr Mladek , Chris Metcalf , open list , Aaron Tomlin , Andrew Morton , "Paul E. McKenney" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Kees Cook Subject: Re: [PATCH] ARM: smp: Remove CPU: shutdown notice Message-ID: <20170118223948.GR27312@n2100.armlinux.org.uk> References: <20170117230714.6799-1-f.fainelli@gmail.com> <20170117232314.GI27312@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 03:39:45PM -0800, Florian Fainelli wrote: > Well, for one it's inconsistent, and it also leaves room for subtle > timing/caching issues with some platforms (OK, maybe not so much). > Improving the speed and consistency was the primary motive. Actually, it's not as inconsistent as you claim. c68b0274fb3c ("ARM: reduce "Booted secondary processor" message to debug level") dropped the corresponding pr_info() in the bringup path to debug level, so to be consistent, this one should be dropped to debug level too. Removing it arguably makes it more inconsistent! So, I'd be willing to accept a patch lowering this to a pr_debug() to make it more consistent with the bringup path, but otherwise the consistency argument doesn't really stand. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.