From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbdARXv4 (ORCPT ); Wed, 18 Jan 2017 18:51:56 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50788 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdARXvx (ORCPT ); Wed, 18 Jan 2017 18:51:53 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 55AC1607C9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 18 Jan 2017 15:51:21 -0800 From: Stephen Boyd To: Russell King - ARM Linux Cc: Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/5] ARM: Makefile: Generalize qcom platform text offset Message-ID: <20170118235121.GW17126@codeaurora.org> References: <20170118232726.22876-1-sboyd@codeaurora.org> <20170118232726.22876-3-sboyd@codeaurora.org> <20170118233115.GV27312@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118233115.GV27312@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18, Russell King - ARM Linux wrote: > On Wed, Jan 18, 2017 at 03:27:23PM -0800, Stephen Boyd wrote: > > Some qcom platforms need a specific text offset because the first > > 2MB of memory is reserved for shared memory. Let's just always > > shift the text segment up by 2MB when ARCH_QCOM is selected so > > that we don't have to specify the specific platforms that exhibit > > this problem in Kconfig. > > I was really hoping that this sillyness would stop, but I guess > expecting it to stop is asking too much... > > Is there really no other option? > The only other option is to make up some qcom specific config like I_HAVE_A_QCOM_SOC_THAT_NEEDS_2MB_OFFSET that can be selected when the configurator (not a word) knows that they are using that SoC. Overall, this practice has stopped inside the company over 3 years ago and has not continued as far as I know. This patch is just taking the easy way out and forcing ARCH_QCOM to always do the shift. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project