From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rpmsg: char: add CONFIG_NET dependency
Date: Wed, 18 Jan 2017 23:08:58 -0800 [thread overview]
Message-ID: <20170119070858.GA17008@builder> (raw)
In-Reply-To: <20170119145503.556971-1-arnd@arndb.de>
On Thu 19 Jan 06:54 PST 2017, Arnd Bergmann wrote:
> Without CONFIG_NET, we get a build failure for the new driver:
>
> ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!
>
> This adds a dependency so we don't try to build the broken configuration.
>
> Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied
Thanks,
Bjorn
prev parent reply other threads:[~2017-01-19 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 14:54 [PATCH] rpmsg: char: add CONFIG_NET dependency Arnd Bergmann
2017-01-19 7:08 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119070858.GA17008@builder \
--to=bjorn.andersson@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox