* [PATCH] rpmsg: char: add CONFIG_NET dependency
@ 2017-01-19 14:54 Arnd Bergmann
2017-01-19 7:08 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-01-19 14:54 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson
Cc: Arnd Bergmann, linux-remoteproc, linux-kernel
Without CONFIG_NET, we get a build failure for the new driver:
ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!
This adds a dependency so we don't try to build the broken configuration.
Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/rpmsg/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
index fa0d582efb3d..f12ac0b28263 100644
--- a/drivers/rpmsg/Kconfig
+++ b/drivers/rpmsg/Kconfig
@@ -7,6 +7,7 @@ config RPMSG
config RPMSG_CHAR
tristate "RPMSG device interface"
depends on RPMSG
+ depends on NET
help
Say Y here to export rpmsg endpoints as device files, usually found
in /dev. They make it possible for user-space programs to send and
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rpmsg: char: add CONFIG_NET dependency
2017-01-19 14:54 [PATCH] rpmsg: char: add CONFIG_NET dependency Arnd Bergmann
@ 2017-01-19 7:08 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2017-01-19 7:08 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel
On Thu 19 Jan 06:54 PST 2017, Arnd Bergmann wrote:
> Without CONFIG_NET, we get a build failure for the new driver:
>
> ERROR: "skb_queue_tail" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_put" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "__alloc_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "kfree_skb" [drivers/rpmsg/rpmsg_char.ko] undefined!
> ERROR: "skb_dequeue" [drivers/rpmsg/rpmsg_char.ko] undefined!
>
> This adds a dependency so we don't try to build the broken configuration.
>
> Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-19 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 14:54 [PATCH] rpmsg: char: add CONFIG_NET dependency Arnd Bergmann
2017-01-19 7:08 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox