From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751279AbdASJjq (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Jan 2017 04:39:46 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35588 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751108AbdASJil (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Jan 2017 04:38:41 -0500
Date: Thu, 19 Jan 2017 10:38:34 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, tglx@linutronix.de,
        peterz@infradead.org, linux-usb@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] x86: add support for earlyprintk via USB3 debug
 port
Message-ID: <20170119093834.GD22865@gmail.com>
References: <1479189731-2728-1-git-send-email-baolu.lu@linux.intel.com>
 <1479189731-2728-3-git-send-email-baolu.lu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1479189731-2728-3-git-send-email-baolu.lu@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Lu Baolu <baolu.lu@linux.intel.com> wrote:

> index 8a12199..c4031b9 100644
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -17,6 +17,7 @@
>  #include <asm/intel-mid.h>
>  #include <asm/pgtable.h>
>  #include <linux/usb/ehci_def.h>
> +#include <linux/usb/xhci-dbgp.h>
>  #include <linux/efi.h>
>  #include <asm/efi.h>
>  #include <asm/pci_x86.h>
> @@ -381,6 +382,10 @@ static int __init setup_early_printk(char *buf)
>  		if (!strncmp(buf, "efi", 3))
>  			early_console_register(&early_efi_console, keep);
>  #endif
> +#ifdef CONFIG_EARLY_PRINTK_XDBC
> +		if (!strncmp(buf, "xdbc", 4))
> +			early_xdbc_parse_parameter(buf + 4);
> +#endif
>  
>  		buf++;
>  	}
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 9c337b0..09d4a56 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -70,6 +70,8 @@
>  #include <linux/tboot.h>
>  #include <linux/jiffies.h>
>  
> +#include <linux/usb/xhci-dbgp.h>
> +
>  #include <video/edid.h>
>  
>  #include <asm/mtrr.h>
> @@ -1096,6 +1098,11 @@ void __init setup_arch(char **cmdline_p)
>  	memblock_set_current_limit(ISA_END_ADDRESS);
>  	memblock_x86_fill();
>  
> +#ifdef CONFIG_EARLY_PRINTK_XDBC
> +	if (!early_xdbc_setup_hardware())
> +		early_xdbc_register_console();
> +#endif
> +
>  	reserve_bios_regions();
>  
>  	if (efi_enabled(EFI_MEMMAP)) {
> -- 
> 2.1.4

Please create proper wrappers in xhci-dbgp.h to not litter generic code with these
#ifdefs.

Thanks,

	Ingo