From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751564AbdASJtF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Jan 2017 04:49:05 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:33164 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751306AbdASJtC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Jan 2017 04:49:02 -0500
Date: Thu, 19 Jan 2017 10:49:14 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>,
        devel@driverdev.osuosl.org,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] staging: fbtft: convert fbtft_reset() to be
 non-atomic
Message-ID: <20170119094914.GA5162@kroah.com>
References: <20170103182949.114385-1-andriy.shevchenko@linux.intel.com>
 <20170103182949.114385-2-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170103182949.114385-2-andriy.shevchenko@linux.intel.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote:
> First of all, fbtft in current state doesn't allow to override GPIOs to be
> optional, like "reset" one. It might be a bug somewhere, but rather out of
> scope of this fix.
> 
> Second, not all GPIOs available on the board would be SoC based, some of them
> might sit on I2C GPIO expanders, for example, on Intel Edison/Arduino, and thus
> any communication with them might sleep.
> 
> Besides that using udelay() and mdelay() is kinda resource wasteful.
> 
> Summarize all of the above, convert fbtft_reset() function to non-atomic
> variant by using gpio_set_value_cansleep(), usleep_range(), and msleep().
> 
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Andy, this series came through with the charmap all corrupted and git
didn't like them at all.  Can you fix up and resend?

thanks,

greg k-h