From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbdASKXe (ORCPT ); Thu, 19 Jan 2017 05:23:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34290 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbdASKXb (ORCPT ); Thu, 19 Jan 2017 05:23:31 -0500 Date: Thu, 19 Jan 2017 11:15:07 +0100 From: Greg KH To: "Luis R. Rodriguez" Cc: ming.lei@canonical.com, wagi@monom.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware/Makefile: force recompilation if makefile changes Message-ID: <20170119101507.GA18592@kroah.com> References: <20170118173156.16060-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170118173156.16060-1-mcgrof@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote: > If you modify the target asm we currently do not force the > recompilation of the firmware files. The target asm is in > the firmware/Makefile, peg this file as a dependency to > require re-compilation of firmware targets when the asm > changes. Why would changing the Makefile require the asm to change? Anyway, this should go through the kbuild tree, not mine, they know Makefiles much better than I do... thanks, greg k-h