From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbdASKfW (ORCPT ); Thu, 19 Jan 2017 05:35:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34522 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbdASKfV (ORCPT ); Thu, 19 Jan 2017 05:35:21 -0500 Date: Thu, 19 Jan 2017 11:35:33 +0100 From: Greg Kroah-Hartman To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/2] of: Add function for generating a DT modalias with a newline Message-ID: <20170119103533.GA19476@kroah.com> References: <20170116204122.5858-1-robh@kernel.org> <20170116204122.5858-2-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116204122.5858-2-robh@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 02:41:22PM -0600, Rob Herring wrote: > The modalias sysfs attr is lacking a newline for DT aliases on platform > devices. The macio and ibmebus correctly add the newline, but open code it. > Introduce a new function, of_device_modalias(), that fills the buffer with > the modalias including the newline and update users of the old > of_device_get_modalias function. > > Signed-off-by: Rob Herring > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Greg Kroah-Hartman > Cc: Frank Rowand > Cc: linuxppc-dev@lists.ozlabs.org Acked-by: Greg Kroah-Hartman