From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751914AbdASKoO (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Jan 2017 05:44:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34322 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751279AbdASKoL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Jan 2017 05:44:11 -0500
Date: Thu, 19 Jan 2017 11:42:55 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: Re: [PATCH 04/11] perf, tools: Support per pmu json aliases
Message-ID: <20170119104255.GA31975@krava>
References: <20170103150833.6694-1-andi@firstfloor.org>
 <20170103150833.6694-5-andi@firstfloor.org>
 <20170118115855.GA11946@krava>
 <20170119001735.GH5460@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170119001735.GH5460@tassilo.jf.intel.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 19 Jan 2017 10:42:59 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 18, 2017 at 04:17:35PM -0800, Andi Kleen wrote:
> > > index 8bffe99d8e3f..4bfc98953aba 100644
> > > --- a/tools/perf/util/pmu.c
> > > +++ b/tools/perf/util/pmu.c
> > > @@ -587,14 +587,13 @@ static struct perf_pmu *pmu_lookup(const char *name)
> > >  	if (pmu_format(name, &format))
> > >  		return NULL;
> > >  
> > > -	if (pmu_aliases(name, &aliases))
> > > +	if (pmu_type(name, &type))
> > >  		return NULL;
> > >  
> > > -	pmu_add_cpu_aliases(&aliases, name);
> > > -
> > > -	if (pmu_type(name, &type))
> > > +	if (pmu_aliases(name, &aliases))
> > >  		return NULL;
> > >  
> > > +	pmu_add_cpu_aliases(&aliases, name);
> > 
> > AFAICS you switched the calls.. how does it matter?
> 
> It avoids lots of duplicate messages with -v (and also is more efficient)

cool, please state that in chagelog.. before/after

thanks,
jirka