From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032AbdASKue (ORCPT ); Thu, 19 Jan 2017 05:50:34 -0500 Received: from mga01.intel.com ([192.55.52.88]:20838 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbdASKub (ORCPT ); Thu, 19 Jan 2017 05:50:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="215196629" From: Andy Shevchenko To: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Thomas Petazzoni , linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 3/5] staging: fbtft: propagate error code from kstrto*() Date: Thu, 19 Jan 2017 12:45:43 +0200 Message-Id: <20170119104545.130561-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170119104545.130561-1-andriy.shevchenko@linux.intel.com> References: <20170119104545.130561-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kstrto*() functions return proper error code. Do propogate it to the user. Acked-by: Noralf Trønnes Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-sysfs.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 8d8bd12b90a1..5922f1b6d8d6 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -4,7 +4,6 @@ static int get_next_ulong(char **str_p, unsigned long *val, char *sep, int base) { char *p_val; - int ret; if (!str_p || !(*str_p)) return -EINVAL; @@ -14,11 +13,7 @@ static int get_next_ulong(char **str_p, unsigned long *val, char *sep, int base) if (!p_val) return -EINVAL; - ret = kstrtoul(p_val, base, val); - if (ret) - return -EINVAL; - - return 0; + return kstrtoul(p_val, base, val); } int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long *curves, -- 2.11.0