From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbdASWSD (ORCPT ); Thu, 19 Jan 2017 17:18:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57764 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893AbdASWSA (ORCPT ); Thu, 19 Jan 2017 17:18:00 -0500 Date: Thu, 19 Jan 2017 23:11:26 +0100 From: Andrea Arcangeli To: Claudio Imbrenda Cc: linux-mm@kvack.org, borntraeger@de.ibm.com, hughd@google.com, chrisw@sous-sol.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm/ksm: improve deduplication of zero pages with colouring Message-ID: <20170119221126.GP10177@redhat.com> References: <1484850953-23941-1-git-send-email-imbrenda@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484850953-23941-1-git-send-email-imbrenda@linux.vnet.ibm.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 19 Jan 2017 22:11:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jan 19, 2017 at 07:35:53PM +0100, Claudio Imbrenda wrote: > +/* Checksum of an empty (zeroed) page */ > +static unsigned int zero_checksum; > + > +/* Whether to merge empty (zeroed) pages with actual zero pages */ > +static bool ksm_use_zero_pages; Both could be defined as __read_mostly.