From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbdATOZZ (ORCPT ); Fri, 20 Jan 2017 09:25:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbdATOZX (ORCPT ); Fri, 20 Jan 2017 09:25:23 -0500 Date: Fri, 20 Jan 2017 15:25:17 +0100 From: Benjamin Tissoires To: Jiri Kosina Cc: Bastien Nocera , Peter Hutterer , Nestor Lopez Casado , Olivier Gay , Simon Wood , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] HID: logitech-hidpp: Add scope to battery Message-ID: <20170120142517.GJ28187@mail.corp.redhat.com> References: <20170117143547.30488-1-benjamin.tissoires@redhat.com> <20170117143547.30488-3-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 20 Jan 2017 14:25:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jan 20 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 17 Jan 2017, Benjamin Tissoires wrote: > > > From: Bastien Nocera > > > > Without a scope defined, UPower assumes that the battery is provide > > power to the computer it's connected to, like a laptop battery or a UPS. > > > > Tested-by: Peter Hutterer > > Signed-off-by: Bastien Nocera > > Signed-off-by: Benjamin Tissoires > > --- > > drivers/hid/hid-logitech-hidpp.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > > index 4eeb550..4aaf237 100644 > > --- a/drivers/hid/hid-logitech-hidpp.c > > +++ b/drivers/hid/hid-logitech-hidpp.c > > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp, > > static enum power_supply_property hidpp_battery_props[] = { > > POWER_SUPPLY_PROP_STATUS, > > POWER_SUPPLY_PROP_CAPACITY, > > + POWER_SUPPLY_PROP_SCOPE, > > Actually, what is the code baseline for this patchset please? I don't > think I've ever seen hidpp_battery_props[] before. > Sorry, I should have mentioned this was on top of your for-4.8/logitech-hidpp-battery (merged with for-next, but which was put on hold since last Summer). Cheers, Benjamin > Thanks, > > -- > Jiri Kosina > SUSE Labs >