From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753377AbdATUZy (ORCPT <rfc822;w@1wt.eu>);
        Fri, 20 Jan 2017 15:25:54 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:34913 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753134AbdATUZe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Jan 2017 15:25:34 -0500
Date: Fri, 20 Jan 2017 21:25:02 +0100
From: Richard Cochran <richardcochran@gmail.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>,
        Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross
 timestamps infrastructure
Message-ID: <20170120202502.GA10368@localhost.localdomain>
References: <20170120122025.665985919@redhat.com>
 <20170120122503.746158230@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170120122503.746158230@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 20, 2017 at 10:20:29AM -0200, Marcelo Tosatti wrote:
> Emulate PTP_SYS_OFFSET by using an arithmetic mean of the
> realtime samples from ->getcrosststamp callback.

This change log is not very informative.

Yes, I can see that the new code calculates a mean.

But WHY is this needed?

And why is this kvm case so special, that it requires its own new flag
within the generic PHC subsystem?

Thanks,
Richard