From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbdAUASb (ORCPT ); Fri, 20 Jan 2017 19:18:31 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36516 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbdAUAS3 (ORCPT ); Fri, 20 Jan 2017 19:18:29 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A9F4260996 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 20 Jan 2017 16:16:48 -0800 From: Stephen Boyd To: Gregory CLEMENT Cc: Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Ziji Hu , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin , Russell King Subject: Re: [PATCH v5 01/12] clk: apn806: Add eMMC clock to system controller driver Message-ID: <20170121001648.GJ20800@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11, Gregory CLEMENT wrote: > From: Konstantin Porotchkin > > Add fixed clock of 400MHz to system controller driver. This clock is > used as SD/eMMC clock source. > > Signed-off-by: Konstantin Porotchkin > Reviewed-by: Omri Itach > Reviewed-by: Hanna Hawa > [fixed up conflicts, added error handling --rmk] > Signed-off-by: Russell King > Signed-off-by: Gregory CLEMENT > --- Acked-by: Stephen Boyd > diff --git a/drivers/clk/mvebu/ap806-system-controller.c b/drivers/clk/mvebu/ap806-system-controller.c > index 8181b919f062..0a785076b0c6 100644 > --- a/drivers/clk/mvebu/ap806-system-controller.c > +++ b/drivers/clk/mvebu/ap806-system-controller.c > @@ -117,6 +117,17 @@ static int ap806_syscon_clk_probe(struct platform_device *pdev) > goto fail3; > } > > + /* eMMC Clock is fixed clock divided by 3 */ > + of_property_read_string_index(np, "clock-output-names", > + 4, &name); This could check for failure and not register the clk if the name isn't there? Then dts can be backwards compatible. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project