From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751290AbdAUSN4 (ORCPT ); Sat, 21 Jan 2017 13:13:56 -0500 Received: from mail.kernel.org ([198.145.29.136]:52596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdAUSNr (ORCPT ); Sat, 21 Jan 2017 13:13:47 -0500 Date: Sat, 21 Jan 2017 10:13:07 -0800 From: Shaohua Li To: Geliang Tang Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] md/bitmap: use i_blocksize() Message-ID: <20170121181307.mbvoe45ca3d7sufv@kernel.org> References: <0a58b38c7ddfbbc8f56cb8d815114bd4357a6016.1484895399.git.geliangtang@gmail.com> <2e7ac27f6ca34bfa01f3b6906fdf409c348e9187.1484895660.git.geliangtang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e7ac27f6ca34bfa01f3b6906fdf409c348e9187.1484895660.git.geliangtang@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 10:29:52PM +0800, Geliang Tang wrote: > Since i_blocksize() helper has been defined in fs.h, use it instead > of open-coding. which tree is this patch applied to? I can't find it in Linus's tree > Signed-off-by: Geliang Tang > --- > drivers/md/bitmap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c > index 9fb2cca..30b1b89 100644 > --- a/drivers/md/bitmap.c > +++ b/drivers/md/bitmap.c > @@ -367,7 +367,7 @@ static int read_page(struct file *file, unsigned long index, > pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE, > (unsigned long long)index << PAGE_SHIFT); > > - bh = alloc_page_buffers(page, 1<i_blkbits, 0); > + bh = alloc_page_buffers(page, i_blocksize(inode), 0); > if (!bh) { > ret = -ENOMEM; > goto out; > @@ -385,10 +385,10 @@ static int read_page(struct file *file, unsigned long index, > goto out; > } > bh->b_bdev = inode->i_sb->s_bdev; > - if (count < (1<i_blkbits)) > + if (count < i_blocksize(inode)) > count = 0; > else > - count -= (1<i_blkbits); > + count -= i_blocksize(inode); > > bh->b_end_io = end_bitmap_write; > bh->b_private = bitmap; > -- > 2.9.3 >