From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbdAVKxV (ORCPT ); Sun, 22 Jan 2017 05:53:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42038 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdAVKxV (ORCPT ); Sun, 22 Jan 2017 05:53:21 -0500 Date: Sun, 22 Jan 2017 18:53:18 +0800 From: Baoquan He To: keescook@chromium.org Cc: linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com Subject: About commit 65fe935d ("x86/KASLR, x86/power: Remove x86 hibernation restrictions") Message-ID: <20170122105318.GD5672@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 22 Jan 2017 10:53:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees, In your commit 65fe935dd, you mentioned with the fix of 70595b479ce1, the x86 hibernation restrictions can be removed. However I didn't find it in Linus's tree. I found commit 65c0554 ("x86/power/64: Fix kernel text mapping corruption during image restoration"), it should be the one you mentioned, but not very sure since it was merged later than your commit. Could you help confirm this? commit 65fe935dd2387a4faf15314c73f5e6d31ef0217e Author: Kees Cook Date: Mon Jun 13 15:10:02 2016 -0700 x86/KASLR, x86/power: Remove x86 hibernation restrictions With the following fix: 70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes control to the image kernel") ... there is no longer a problem with hibernation resuming a KASLR-booted kernel image, so remove the restriction. commit 65c0554b73c920023cc8998802e508b798113b46 Author: Rafael J. Wysocki Date: Thu Jun 30 18:11:41 2016 +0200 x86/power/64: Fix kernel text mapping corruption during image restoration Logan Gunthorpe reports that hibernation stopped working reliably for him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table and rodata). Thanks Baoquan