Re: [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h

Paul Gortmaker
2017-01-26T14:50:54Z

[Re: [PATCH v2] openrisc: migrate exception table users off module.h and onto extable.h] On 26/01/2017 (Thu 14:53) Stafford Horne wrote:

> On Wed, Jan 25, 2017 at 04:40:46PM -0500, Paul Gortmaker wrote:
> > These files were only including module.h for exception table related
> > functions. We've now separated that content out into its own file
> > "extable.h" so now move over to that and avoid all the extra header
> > content in module.h that we don't really need to compile these files.
> >
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Cc: Jonas Bonn <jonas@southpole.se>
> > Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Cc: openrisc@lists.librecores.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> >
> > [v2: add traps.c to conversion, as without a toolchain, I'm at the
> > mercy of the things found by kbuild; fixing them iteratively... ]
> >
> > arch/openrisc/kernel/traps.c | 2 +-
> > arch/openrisc/mm/fault.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
> > index a4574cb4b0fb..73abb3ff4fa3 100644
> > --- a/arch/openrisc/kernel/traps.c
> > +++ b/arch/openrisc/kernel/traps.c
> > @@ -23,7 +23,7 @@
> > #include <linux/init.h>
> > #include <linux/sched.h>
> > #include <linux/kernel.h>
> > -#include <linux/module.h>
> > +#include <linux/exception.h>
>
> Is this correct or did you want extable.h?

Gah, of course. Thanks for spotting that. It will be good to have a
working cross compiler for or32 someday to spot thinko items like this.

Thanks,
Paul.
--

>
> > #include <linux/kmod.h>
> > #include <linux/string.h>
> > #include <linux/errno.h>
> > diff --git a/arch/openrisc/mm/fault.c b/arch/openrisc/mm/fault.c
> > index b1a7435e786a..53592a639744 100644
> > --- a/arch/openrisc/mm/fault.c
> > +++ b/arch/openrisc/mm/fault.c
> > @@ -17,7 +17,7 @@
> >
> > #include <linux/mm.h>
> > #include <linux/interrupt.h>
> > -#include <linux/module.h>
> > +#include <linux/extable.h>
> > #include <linux/sched.h>
> >
> > #include <linux/uaccess.h>
> > --
> > 2.11.0
> >