From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbdAVUlz (ORCPT ); Sun, 22 Jan 2017 15:41:55 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:52837 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdAVUlx (ORCPT ); Sun, 22 Jan 2017 15:41:53 -0500 Date: Sun, 22 Jan 2017 21:41:10 +0100 From: Andreas Klinger To: Jonathan Cameron Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ktsai@capellamicro.com, wsa@the-dreams.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, trivial@kernel.org, mranostay@gmail.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/3] iio: distance: srf08: add driver ABI documentation Message-ID: <20170122204110.GA1840@andreas> References: <20170117135006.GA22903@andreas> <2e87aeed-a611-e160-c245-f5b16f2ef304@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e87aeed-a611-e160-c245-f5b16f2ef304@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:lq/f/txZY1blppbnBt7LDrrBc7QKA97+c0hpKOoiIiLtTmZH2h9 YObaeIK5ksVScHk/k1sFRL+6znSmNOH0SAjrQlt/WkOY4YZxNsva5VmJKXm6ZusaiCkT75v Znmdc0r9guWtmj0u9r0WQq1MgrYtyfBs2KAfxYsQ4cVymtBHe3P5XpD/VHyfyrsBHUGb9WK MIcHIZ5CfFEILH8jqKInw== X-UI-Out-Filterresults: notjunk:1;V01:K0:4JfvQ8Rwf1c=:+mfWjQb/89nfpBroU66lyQ 6WdlP5JfDbp8ktmnal2yCnEEvQqCQR5Yk5vn7cgBkaToB6olT+Riz3DsOUVXGpB5+BZVMhaqK lbCmCls18ocn5zO6SBb6INiQnWuZ3wgmshOj5GuAI45TdHHxOYuhbp/sqImoHdsP9CirJAWLY Tpz7SEo2EaILzB5yXXcc1al+nVQpoULQYAB6pitzZkwHsMPbMWdB4XkmlqRXEQgOgxklDAzj2 v7J438bXkwft1K3t5eA+MG7KfbsLXKPoNq6f5ZZLzE3Aaq3lgDobxcyK2vDYxIAtPc+nt84yL /NRknJUcvPoCKlGW2sJYM6ZI888HLy5JS+ZtbaWxFYZDe4eyxY/AvMYXc4x3f22zIH0HpBvGE 7M9aYo+EDHqVgdTSWLC97V0VpeshXOkau+b4xZMCViCk/HBK0UJQMUY2u/9ZUGo8fd7XDVMtZ aJhLzqx2eedTIOjsLZu3CZvxx3O5zr407Ke3+9CdHFGP4W4Ys+0fz5mzMFBh6rtTSfoKn/zJL HGEHpT+MdqtvqF8jyHVHeMqwsk/tW06gKDutSA7UUjX6H0IlykeXXz61X8/co1EMX6cbbR5jE CpjWbPAH1dhdkdpJZsi3V9JXsENIkMX42injVua1457V9ZH0L05/cR8RX8SkIDqds48O/Hfmm aQh5TNat2Lg6rUOcb3FMPQtMbOPWaiZOYkpMWl5c57IPeWpextqxeDE44BFxDS0gQ0Ao= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, see question below. Andreas Jonathan Cameron schrieb am Sun, 22. Jan 13:41: > On 17/01/17 13:50, Andreas Klinger wrote: > > Add sysfs-bus-iio-distance-srf08 for individual attributes of the driver, > > especially: > > - sensitivity which the device documentation calls gain for amplifying the > > signal > > - max_range for limiting the maximum distance for expected echos and > > therefore limiting the time waiting for telegrams > > > > Signed-off-by: Andreas Klinger > > --- > > .../ABI/testing/sysfs-bus-iio-distance-srf08 | 27 ++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-distance-srf08 > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-distance-srf08 b/Documentation/ABI/testing/sysfs-bus-iio-distance-srf08 > > new file mode 100644 > > index 000000000000..e96c28064748 > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-bus-iio-distance-srf08 > > @@ -0,0 +1,27 @@ > > +What /sys/bus/iio/devices/iio:deviceX/in_distance_raw > > +Date: January 2017 > > +KernelVersion: 4.11 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Get the current distance in meters between the sensor and > > + the first object recognized > Generally no need to document what are effectively standard elements. > Just leads to the possibility of disagreements in the docs! > Still no harm here really. > > + > > +What /sys/bus/iio/devices/iio:deviceX/sensor_sensitivity > > +Date: January 2017 > > +KernelVersion: 4.11 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Show or set the gain boost of the amp, from 0-31 range. > > + default 31 > > + > > +What /sys/bus/iio/devices/iio:deviceX/sensor_max_range > > +Date: January 2017 > > +KernelVersion: 4.11 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Show or set the maximum range between the sensor and the > > + first object echoed in millimeters. > > + This setting limits the time the driver is waiting for a > > + echo. > > + Can be set between 43 and 11008 in a grid of 43 mm. > > + default 6020 > This needs to be in the same units as the range - so m. Just to clarify: There should be a floating point number be passed to the driver and being parsed there, e. g.: 0.043 or 6.020 right? Or should this number be passed using the scale attribute like the raw value does? So that the scale is used by both the value itself and the attribute. > I'm not 100% sure this is the best ABI we can do for this. However, supporting > this as a legacy abi if we come up with something more general will be a very > small burden, so lets not stall the driver on this! > > Jonathan > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --