From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-input@vger.kernel.org,
Zhang Jiejing <jiejing.zhang@freescale.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
Date: Sun, 22 Jan 2017 14:31:55 -0800 [thread overview]
Message-ID: <20170122223155.GF31009@dtor-ws> (raw)
In-Reply-To: <dd170278-d556-2f73-cdbe-ee69f9a19423@roeck-us.net>
On Sun, Jan 22, 2017 at 03:25:57AM -0800, Guenter Roeck wrote:
> On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> >Nobody calls input_get_drvdata() so setting it is not required.
> >
> >Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> Surprisingly, there is about a dozen of those. I'll send a series of
> coccinelle generated patches later.
Cool, thanks.
>
> Guenter
>
> >---
> > drivers/input/touchscreen/max11801_ts.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> >index d87b89da114e..a595ae5284e3 100644
> >--- a/drivers/input/touchscreen/max11801_ts.c
> >+++ b/drivers/input/touchscreen/max11801_ts.c
> >@@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
> > __set_bit(BTN_TOUCH, input_dev->keybit);
> > input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
> > input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> >- input_set_drvdata(input_dev, data);
> >
> > max11801_ts_phy_init(data);
> >
> >
>
--
Dmitry
prev parent reply other threads:[~2017-01-22 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 7:38 [PATCH] Input: max11801_ts - drop call to input_set_drvdata() Dmitry Torokhov
2017-01-22 11:25 ` Guenter Roeck
2017-01-22 22:31 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122223155.GF31009@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=jiejing.zhang@freescale.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox