From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750856AbdAWJBl (ORCPT ); Mon, 23 Jan 2017 04:01:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdAWJBk (ORCPT ); Mon, 23 Jan 2017 04:01:40 -0500 Date: Mon, 23 Jan 2017 10:01:37 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , David Ahern , Namhyung Kim , Peter Zijlstra , lkml , Ingo Molnar Subject: Re: [PATCH 2/4] perf hists browser: Add e/c key handlers to expand callchain for current entry Message-ID: <20170123090137.GA25780@krava> References: <1484904032-11040-1-git-send-email-jolsa@kernel.org> <1484904032-11040-3-git-send-email-jolsa@kernel.org> <20170120164133.GJ14872@kernel.org> <20170120164326.GK14872@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170120164326.GK14872@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 23 Jan 2017 09:01:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 01:43:26PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 20, 2017 at 01:41:33PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Jan 20, 2017 at 10:20:30AM +0100, Jiri Olsa escreveu: > > > Currently we allow only to expand or collapse all entries > > > in the browser with E or C keys. Allow user to expand or > > > collapse only current entry in the browser with e or c key. > > > > I guess we can start with this but then fix it to collapse just the > > subtree, not the whole tree for the current hist_entry, for big > > callchains we can have multiple sub(sub)trees, being able to > > expand/collapse just from where we are in a callchain seems even better. > > > > Applying anyway, better than what we have now, > > Also I think that pressing 'e' on an already expanded tree should mean > 'c', i.e. make it a toggle, so that we can go back and forth faster. yep, that was my impression also, but wanted to keep the current way I think we could use only C/c keys to toggle 'collapse all'/'collapse current' thanks, jirka