From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbdAWJQQ (ORCPT ); Mon, 23 Jan 2017 04:16:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:48487 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdAWJQN (ORCPT ); Mon, 23 Jan 2017 04:16:13 -0500 Date: Mon, 23 Jan 2017 10:16:10 +0100 From: Johannes Thumshirn To: SF Markus Elfring Cc: linux-block@vger.kernel.org, Jens Axboe , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() Message-ID: <20170123091610.GB3517@linux-x5ow.site> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2017 at 09:32:19AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Jan 2017 21:40:38 +0100 > > A local variable was set to an error code before a concrete error situation > was detected. Thus move the corresponding assignment into an if branch > to indicate a software failure there. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- See my answer to the last patch. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850