From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751112AbdAWLcd (ORCPT ); Mon, 23 Jan 2017 06:32:33 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35435 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdAWLcb (ORCPT ); Mon, 23 Jan 2017 06:32:31 -0500 Date: Mon, 23 Jan 2017 11:36:30 +0000 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Laxman Dewangan , Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Message-ID: <20170123113630.GD16020@dell> References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1484314449-10060-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > If a driver is only used in DT platforms, there's no need to get the > i2c_device_id as an argument of the probe function. Since this data > can be get from the matching of_device_id. > > There's a temporary .probe_new field in struct i2c_driver that can be > used as probe callback for the case when i2c_device_id won't be used. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 3/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 3/4. > > drivers/mfd/max77686.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 33dd09493605..896c1bf85acc 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -172,8 +172,7 @@ static const struct of_device_id max77686_pmic_dt_match[] = { > }; > MODULE_DEVICE_TABLE(of, max77686_pmic_dt_match); > > -static int max77686_i2c_probe(struct i2c_client *i2c, > - const struct i2c_device_id *id) > +static int max77686_i2c_probe(struct i2c_client *i2c) > { > struct max77686_dev *max77686 = NULL; > unsigned int data; > @@ -294,7 +293,7 @@ static struct i2c_driver max77686_i2c_driver = { > .pm = &max77686_pm, > .of_match_table = of_match_ptr(max77686_pmic_dt_match), > }, > - .probe = max77686_i2c_probe, > + .probe_new = max77686_i2c_probe, > .id_table = max77686_i2c_id, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog