From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table
Date: Mon, 23 Jan 2017 11:39:59 +0000 [thread overview]
Message-ID: <20170123113959.GE16020@dell> (raw)
In-Reply-To: <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com>
On Mon, 16 Jan 2017, Javier Martinez Canillas wrote:
> Hello Chanwoo,
>
> Thanks for the review.
>
> On 01/16/2017 03:46 AM, Chanwoo Choi wrote:
> > Hi,
> >
> > I think that this patch better to squash with patch3.
> > After applying the patch3, this driver doesn't use
> > the max77686_i2c_id table.
> >
>
> I usually prefer to separate each change in a different patch,
> AFAICT moving to use the .probe_new callback and removing the
> I2C id table are two different changes.
>
> I can squash if that's the correct approach though, I will let
> Lee decide.
This should really be a single patch, as the previous one leaves this
code redundant, but ... meh!
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-23 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 13:34 [PATCH v2 0/4] mfd: max77686: Remove unneeded non-OF code in driver Javier Martinez Canillas
2017-01-13 13:34 ` [PATCH v2 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data Javier Martinez Canillas
2017-01-16 6:30 ` Chanwoo Choi
2017-01-23 11:35 ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper Javier Martinez Canillas
2017-01-13 14:09 ` Krzysztof Kozlowski
2017-01-16 6:34 ` Chanwoo Choi
2017-01-23 11:36 ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Javier Martinez Canillas
2017-01-16 6:37 ` Chanwoo Choi
2017-01-23 11:36 ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas
2017-01-16 6:46 ` Chanwoo Choi
2017-01-16 12:30 ` Javier Martinez Canillas
2017-01-23 11:39 ` Lee Jones [this message]
2017-01-23 11:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123113959.GE16020@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=krzk@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).