From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751058AbdAWLgB (ORCPT ); Mon, 23 Jan 2017 06:36:01 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37030 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdAWLgA (ORCPT ); Mon, 23 Jan 2017 06:36:00 -0500 Date: Mon, 23 Jan 2017 11:39:59 +0000 From: Lee Jones To: Javier Martinez Canillas Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Message-ID: <20170123113959.GE16020@dell> References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-5-git-send-email-javier@osg.samsung.com> <587C6C36.5070606@samsung.com> <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jan 2017, Javier Martinez Canillas wrote: > Hello Chanwoo, > > Thanks for the review. > > On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > > Hi, > > > > I think that this patch better to squash with patch3. > > After applying the patch3, this driver doesn't use > > the max77686_i2c_id table. > > > > I usually prefer to separate each change in a different patch, > AFAICT moving to use the .probe_new callback and removing the > I2C id table are two different changes. > > I can squash if that's the correct approach though, I will let > Lee decide. This should really be a single patch, as the previous one leaves this code redundant, but ... meh! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog