From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdAWLgO (ORCPT ); Mon, 23 Jan 2017 06:36:14 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38893 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbdAWLgM (ORCPT ); Mon, 23 Jan 2017 06:36:12 -0500 Date: Mon, 23 Jan 2017 11:40:10 +0000 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Laxman Dewangan , Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Message-ID: <20170123114010.GF16020@dell> References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-5-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1484314449-10060-5-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 4/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4. > > drivers/mfd/max77686.c | 8 -------- > 1 file changed, 8 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 896c1bf85acc..b0e8e13c0049 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c) > return 0; > } > > -static const struct i2c_device_id max77686_i2c_id[] = { > - { "max77686", TYPE_MAX77686 }, > - { "max77802", TYPE_MAX77802 }, > - { } > -}; > -MODULE_DEVICE_TABLE(i2c, max77686_i2c_id); > - > #ifdef CONFIG_PM_SLEEP > static int max77686_suspend(struct device *dev) > { > @@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = { > .of_match_table = of_match_ptr(max77686_pmic_dt_match), > }, > .probe_new = max77686_i2c_probe, > - .id_table = max77686_i2c_id, > }; > > module_i2c_driver(max77686_i2c_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog