From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbdAWLys (ORCPT ); Mon, 23 Jan 2017 06:54:48 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36000 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbdAWLyr (ORCPT ); Mon, 23 Jan 2017 06:54:47 -0500 Date: Mon, 23 Jan 2017 11:58:45 +0000 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: tps65912: Export OF device ID table as module aliases Message-ID: <20170123115845.GI16020@dell> References: <1484577718-10589-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1484577718-10589-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jan 2017, Javier Martinez Canillas wrote: > The I2C core always reports a MODALIAS of the form i2c: even if the > device was registered via OF, this means that exporting the OF device ID > table device aliases in the module is not needed. But in order to change > how the core reports modaliases to user-space, it's better to export it. > > Before this patch: > > $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias > alias: i2c:tps65912 > > After this patch: > > $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias > alias: of:N*T*Cti,tps65912C* > alias: of:N*T*Cti,tps65912 > alias: i2c:tps65912 > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/tps65912-i2c.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/tps65912-i2c.c b/drivers/mfd/tps65912-i2c.c > index 45871403f995..785d19f6f7c9 100644 > --- a/drivers/mfd/tps65912-i2c.c > +++ b/drivers/mfd/tps65912-i2c.c > @@ -27,6 +27,7 @@ static const struct of_device_id tps65912_i2c_of_match_table[] = { > { .compatible = "ti,tps65912", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, tps65912_i2c_of_match_table); > > static int tps65912_i2c_probe(struct i2c_client *client, > const struct i2c_device_id *ids) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog