From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbdAWWdk (ORCPT ); Mon, 23 Jan 2017 17:33:40 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:57523 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbdAWWdg (ORCPT ); Mon, 23 Jan 2017 17:33:36 -0500 Date: Mon, 23 Jan 2017 14:33:19 -0800 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH v2 tip/core/rcu 02/18] lockdep: Make RCU suspicious-access splats use pr_err Message-ID: <20170123223319.GB1351@cloud> References: <20170118025316.GB2042@linux.vnet.ibm.com> <1484708037-2523-2-git-send-email-paulmck@linux.vnet.ibm.com> <20170121204023.im7ysfl2jdix5jox@x> <20170123193016.GH28085@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170123193016.GH28085@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 11:30:16AM -0800, Paul E. McKenney wrote: > On Sat, Jan 21, 2017 at 12:40:23PM -0800, Josh Triplett wrote: > > On Tue, Jan 17, 2017 at 06:53:41PM -0800, Paul E. McKenney wrote: > > > This commit switches RCU suspicious-access splats use pr_err() > > > instead of the current INFO printk()s. This change makes it easier > > > to automatically classify splats. > > > > > > Reported-by: Dmitry Vyukov > > > Signed-off-by: Paul E. McKenney > > > --- > > > kernel/locking/lockdep.c | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > > index 7c38f8f3d97b..a74c0630172a 100644 > > > --- a/kernel/locking/lockdep.c > > > +++ b/kernel/locking/lockdep.c > > > @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s) > > > #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */ > > > /* Note: the following can be executed concurrently, so be careful. */ > > > printk("\n"); > > > - printk("===============================\n"); > > > - printk("[ INFO: suspicious RCU usage. ]\n"); > > > + pr_err("===============================\n"); > > > + pr_err("[ suspicious RCU usage. ]\n"); > > > > While re-adding the square bracket makes it symmetric, this change still > > seems odd, and unrelated to the switch to pr_err. You could change it > > to "ERR:" if you want, if "INFO:" feels inaccurate to you. > > So this would be OK? > > pr_err("[ ERR: suspicious RCU usage. ]\n"); > > (Changed to this as a best guess, but please let me know.) Yeah, that seems fine. Sorry to nitpick this; it just otherwise seemed entirely unrelated to the rest of the change.