From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751213AbdAXPSH (ORCPT ); Tue, 24 Jan 2017 10:18:07 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51048 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbdAXPSF (ORCPT ); Tue, 24 Jan 2017 10:18:05 -0500 Date: Tue, 24 Jan 2017 16:17:45 +0100 From: Peter Zijlstra To: Sebastian Andrzej Siewior Cc: Ingo Molnar , linux-kernel@vger.kernel.org, tglx@linutronix.de, Juri Lelli Subject: Re: [PATCH] kernel/sched/rt: Add a rescheduling point Message-ID: <20170124151745.GM3093@worktop> References: <20170124144006.29821-1-bigeasy@linutronix.de> <20170124144353.ehacjtgqduwy23dy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170124144353.ehacjtgqduwy23dy@linutronix.de> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2017 at 03:43:54PM +0100, Sebastian Andrzej Siewior wrote: > On 2017-01-24 15:40:06 [+0100], To Peter Zijlstra wrote: > > Since the change in commit fd7a4bed1835 ("sched, rt: Convert > > switched_{from, to}_rt() / prio_changed_rt() to balance callbacks") we > > don't reschedule a task under certain circumstances: > > |switched_to_dl() > |{ > |… > | if (rq->curr != p) { > | #ifdef CONFIG_SMP > | if (tsk_nr_cpus_allowed(p) > 1 && rq->dl.overloaded) > | queue_push_tasks(rq); > | #else > | if (dl_task(rq->curr)) > | check_preempt_curr_dl(rq, p, 0); > | else > | resched_curr(rq); > | #endif > | } > | } > > This looks like it asks for a similar change. Indeed.