From: Vinod Koul <vinod.koul@intel.com>
To: iari@itu.dk
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Iago Abal <mail@iagoabal.eu>
Subject: Re: [PATCH] dmaengine: pl330: fix double lock
Date: Wed, 25 Jan 2017 15:35:57 +0530 [thread overview]
Message-ID: <20170125100557.GD3573@localhost> (raw)
In-Reply-To: <1484139621-18706-1-git-send-email-iari@itu.dk>
On Wed, Jan 11, 2017 at 02:00:21PM +0100, iari@itu.dk wrote:
> From: Iago Abal <mail@iagoabal.eu>
>
> The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
> following double-lock bug:
>
> Double lock:
> 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
> 2. call to function `pl330_release_channel' immediately after;
> 3. call to function `dma_pl330_rqcb' in line 1753;
> 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
>
> I have fixed it as suggested by Marek Szyprowski.
>
> First, I have replaced `pch->lock' with `pl330->lock' in functions
> `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
> the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
>
> NOTE that, as a result, `pl330_free_chan_resources' executes
> `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
> whereas in the rest of the code `pch->work_list' is protected by
> `pch->lock'. I don't know if this may cause race conditions. Similarly
> `pch->cyclic' is written by `pl330_alloc_chan_resources' under
> `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
>
> Second, I have removed locking from `pl330_request_channel' and
> `pl330_release_channel' functions. Function `pl330_request_channel' is
> only called from `pl330_alloc_chan_resources', so the lock is already
> held. Function `pl330_release_channel' is called from
> `pl330_free_chan_resources', which already holds the lock, and from
> `pl330_del'. Function `pl330_del' is called in an error path of
> `pl330_probe' and at the end of `pl330_remove', but I assume that there
> cannot be concurrent accesses to the protected data at those points.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2017-01-25 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170111130113epcas5p3e450202a65d15a1479701a0ef0d674a0@epcas5p3.samsung.com>
2017-01-11 13:00 ` [PATCH] dmaengine: pl330: fix double lock iari
2017-01-11 13:20 ` Marek Szyprowski
2017-01-25 10:05 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125100557.GD3573@localhost \
--to=vinod.koul@intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=iari@itu.dk \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mail@iagoabal.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox