Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

Thierry Reding
2017-01-25T11:02:57Z

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote:
> Depthcharge (the payload used with cros devices) will attempt to detect
> boards using their revision. This includes all the known revisions for
> the nyan-big board so that the dtb can be selected preferably.
>
> Defining compatibly revisions allows depthcharge to select the kernel
> via the revision it detects instead of using the default kernel. This
> allows having a FIT image with multiple kernels for multiple devices.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)

I've applied this, with a small change, see below.

> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
> index 67d7cfb32541..f12ece9b76a6 100644
> --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> @@ -6,7 +6,12 @@
>
> / {
> model = "Acer Chromebook 13 CB5-311";
> - compatible = "google,nyan-big", "nvidia,tegra124";
> + compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
> + "google,nyan-big-rev5", "google,nyan-big-rev4",
> + "google,nyan-big-rev3", "google,nyan-big-rev2",
> + "google,nyan-big-rev5", "google,nyan-big-rev4",

This line is the same as two lines above, so I've removed this one. I've
also used slightly different padding (two tabs and align to the first
string in the first line with spaces) to make it consistent with other
string lists in the file.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]