Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

Jani Nikula
2017-01-25T11:33:34Z

(Now without the typo in Daniel's address; apologies for the extra
noise.)

On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>> arch/x86/kernel/early-quirks.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>>
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>> INTEL_SKL_IDS(&gen9_early_ops),
>>> INTEL_BXT_IDS(&gen9_early_ops),
>>> INTEL_KBL_IDS(&gen9_early_ops),
>>> + INTEL_GLK_IDS(&gen9_early_ops),
>>> };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center