From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbdAYNva (ORCPT ); Wed, 25 Jan 2017 08:51:30 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48232 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbdAYNv2 (ORCPT ); Wed, 25 Jan 2017 08:51:28 -0500 Date: Wed, 25 Jan 2017 14:51:24 +0100 From: Pavel Machek To: Laura Abbott Cc: Kees Cook , Jason Wessel , Jonathan Corbet , Russell King , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Martin Schwidefsky , Heiko Carstens , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Rob Herring , "Rafael J. Wysocki" , Len Brown , Mark Rutland , Jessica Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-pm@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA Message-ID: <20170125135124.GA20896@amd> References: <1484789346-21012-1-git-send-email-labbott@redhat.com> <1484789346-21012-2-git-send-email-labbott@redhat.com> <20170119075341.GA14530@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2017-01-25 12:21:05, Laura Abbott wrote: > On 01/19/2017 08:53 AM, Pavel Machek wrote: > >On Wed 2017-01-18 17:29:05, Laura Abbott wrote: > >> > >>Despite the word 'debug' in CONFIG_DEBUG_RODATA, this kernel option > >>provides key security features that are to be expected on a modern > >>system. Change the name to CONFIG_HARDENED_PAGE_MAPPINGS which more > >>accurately describes what this option is intended to do. > > > >I think this is bad change. CONFIG_DEBUG_RODATA is describing what it > >does, CONFIG_HARDENED_PAGE_MAPPINGS is advertising. > > > >We don't do advertising, and we don't force people to re-answer the > >config questions without good reason. > > > >CONFIG_HARDENED_RODATA might fix the first problem, but not the second > >one. > > > > Pavel > > =09 >=20 > (Apologies, my SMTP was set up incorrectly so my response didn't > actually get sent out) >=20 > CONFIG_DEBUG_RODATA isn't describing what it does though. It misses > that this config may handle much more than just rodata. I think > Mark Rutland's suggestion of STRICT_KERNEL_RWX might be more > descriptive. CONFIG_BUG=3Dy CONFIG_LBDAF=3Dy CONFIG_PM_OPP=3Dy =2E.it is config option. It is not description of the feature. People are living with that config option for a while. I'd keep it. Maybe you can go from CONFIG_DEBUG_RODATA to CONFIG_RODATA... (but you'll still have people re-answer config option.) Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliIrVwACgkQMOfwapXb+vKDIQCeObwXTavXbjg0vV7fo6GrI6mz +TEAn3KekWFvtsx4J9UCa0MsjGe1ktv4 =Av9j -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--