From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752054AbdAYNyT (ORCPT ); Wed, 25 Jan 2017 08:54:19 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:53764 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbdAYNyP (ORCPT ); Wed, 25 Jan 2017 08:54:15 -0500 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Markus Elfring , Adrian Hunter , Alexander Shishkin , He Kuang , Jiri Olsa , Milian Wolff , Peter Zijlstra , Ravi Bangoria , Wang Nan , kernel-janitors@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 12/23] perf probe: Delete an unnecessary check in try_to_find_absolute_address() Date: Wed, 25 Jan 2017 10:53:39 -0300 Message-Id: <20170125135350.22983-13-acme@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170125135350.22983-1-acme@kernel.org> References: <20170125135350.22983-1-acme@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Remove a condition check which is unnecessary at the end because this source code place should usually only be reached with a non-zero pointer. Signed-off-by: Markus Elfring Acked-by: Masami Hiramatsu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: He Kuang Cc: Jiri Olsa Cc: Milian Wolff Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Wang Nan Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/probe-event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4a57c8a60bd9..cdfc468d4d5f 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, return 1; errout: - if (*tevs) { - clear_probe_trace_events(*tevs, 1); - *tevs = NULL; - } + clear_probe_trace_events(*tevs, 1); + *tevs = NULL; return err; } -- 2.9.3