[PATCH 07/23] perf tools: Add one liner warning for disabled features

Arnaldo Carvalho de Melo
2017-01-25T13:59:35Z

From: Andi Kleen <ak@linux.intel.com>

Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.

Currently enabled for XED and BABELTRACE.

Committer notes:

Testing it:

$ make O=/tmp/build/perf -C tools/perf
make: Entering directory '/home/acme/git/linux/tools/perf'
Makefile.config:853: Disabled features, need explicit enabling by user: XED LIBBABELTRACE
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
$ make O=/tmp/build/perf XED=1 -C tools/perf
make: Entering directory '/home/acme/git/linux/tools/perf'
Makefile.config:853: Disabled features, need explicit enabling by user: LIBBABELTRACE
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
$ make O=/tmp/build/perf LIBBABELTRACE=1 -C tools/perf
make: Entering directory '/home/acme/git/linux/tools/perf'
Makefile.config:853: Disabled features, need explicit enabling by user: XED
CC /tmp/build/perf/arch/common.o
<SNIP>
$
$ make O=/tmp/build/perf XED=1 LIBBABELTRACE=1 -C tools/perf
make: Entering directory '/home/acme/git/linux/tools/perf'
BUILD: Doing 'make -j4' parallel build
make: Leaving directory '/home/acme/git/linux/tools/perf'
$

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: http://lkml.kernel.org/r/20170103183946.GK27864@kernel.org
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170119014150.19218-3-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.config | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index fd798d118739..0caa11979279 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
NO_LIBDW_DWARF_UNWIND := 1
endif

+DISABLED_FEATURES =
+
ifeq ($(LIBUNWIND_LIBS),)
NO_LIBUNWIND := 1
endif
@@ -701,6 +703,8 @@ ifdef XED
else
msg := $(warning No xed found, disables x86 disassembler support, please install xed);
endif
+else
+ DISABLED_FEATURES += XED
endif

ifndef NO_LZMA
@@ -775,6 +779,8 @@ ifdef LIBBABELTRACE
else
msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
endif
+else
+ DISABLED_FEATURES += LIBBABELTRACE
endif

ifndef NO_AUXTRACE
@@ -846,6 +852,10 @@ ifdef LIBCLANGLLVM
endif
endif

+ifneq ($(DISABLED_FEATURES),)
+ $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
# Among the variables below, these:
# perfexecdir
# template_dir
--
2.9.3