From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>,
Joe Mario <jmario@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 05/23] perf c2c report: Coalesce by default only by pid,iaddr
Date: Wed, 25 Jan 2017 10:53:32 -0300 [thread overview]
Message-ID: <20170125135350.22983-6-acme@kernel.org> (raw)
In-Reply-To: <20170125135350.22983-1-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
It seems to be the most used argument for -c option so far. In the
beginning when you want to have the overall process report, so it makes
sense to make it the default one.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1484904032-11040-5-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf-c2c.txt | 2 +-
tools/perf/builtin-c2c.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
index 3f06730c7f47..2da07e51e119 100644
--- a/tools/perf/Documentation/perf-c2c.txt
+++ b/tools/perf/Documentation/perf-c2c.txt
@@ -248,7 +248,7 @@ output fields set for caheline offsets output:
Code address, Code symbol, Shared Object, Source line
dso - coalesced by shared object
-By default the coalescing is setup with 'pid,tid,iaddr'.
+By default the coalescing is setup with 'pid,iaddr'.
STDIO OUTPUT
------------
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 616cb1418c3f..e2b21723bbf8 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -58,7 +58,7 @@ struct c2c_hist_entry {
struct hist_entry he;
};
-static char const *coalesce_default = "pid,tid,iaddr";
+static char const *coalesce_default = "pid,iaddr";
struct perf_c2c {
struct perf_tool tool;
--
2.9.3
next prev parent reply other threads:[~2017-01-25 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 13:53 [GIT PULL 00/23] perf/core improvements and fixes Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 01/23] perf unwind: Fix looking up dwarf unwind stack info Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 02/23] perf hists browser: Put hist_entry folding logic into single function Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 03/23] perf hists browser: Add e/c hotkeys to expand/collapse callchain for current entry Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 04/23] perf c2c report: Display Total records column in offset view Arnaldo Carvalho de Melo
2017-01-25 13:53 ` Arnaldo Carvalho de Melo [this message]
2017-01-25 13:53 ` [PATCH 06/23] perf tools: Add probing for the XED disassembler library Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 07/23] perf tools: Add one liner warning for disabled features Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 08/23] perf tools: Add disassembler for x86 using the XED library Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 09/23] perf script: Add support for printing assembler Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 10/23] perf script: Add "brstackasm" output for branch stacks Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 11/23] perf probe: Fix wrong register name for arm64 Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 12/23] perf probe: Delete an unnecessary check in try_to_find_absolute_address() Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 13/23] perf probe: Delete an unnecessary assignment " Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 14/23] tools lib bpf: Fix map offsets in relocation Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 15/23] tools lib bpf: Define prog_type fns with macro Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 16/23] tools lib bpf: Add set/is helpers for all prog types Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 17/23] tools lib bpf: Add libbpf_get_error() Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 18/23] perf scripting perl: Do not die() when not founding event for a type Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 19/23] perf tools: Propagate perf_config() errors Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 20/23] perf util: Save pid-cmdline mapping into tracing header Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 21/23] perf util: Add more debug message on failure path Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 22/23] perf ftrace: Introduce new 'ftrace' tool Arnaldo Carvalho de Melo
2017-01-25 13:53 ` [PATCH 23/23] perf ftrace: Make 'function_graph' be the default tracer Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125135350.22983-6-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox